-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++][Parquet] Debug Build might fail in DictEncoder
dtor checking
#38117
Comments
@pitrou I've draft a basic fixing for this #38118 I change
And change DCHECK(aborted_ || !buffered_indices_.empty()); Any idea is ok for me :-) |
pitrou
pushed a commit
that referenced
this issue
Oct 19, 2023
…log (#38118) ### Rationale for this change This is a minor change, just change `DCHECK` to warning log. ### What changes are included in this PR? change `DCHECK` to warning log. ### Are these changes tested? no, I don't know how to test this, any idea is welcome. ### Are there any user-facing changes? no * Closes: #38117 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this issue
Oct 23, 2023
…rning log (apache#38118) ### Rationale for this change This is a minor change, just change `DCHECK` to warning log. ### What changes are included in this PR? change `DCHECK` to warning log. ### Are these changes tested? no, I don't know how to test this, any idea is welcome. ### Are there any user-facing changes? no * Closes: apache#38117 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
…rning log (apache#38118) ### Rationale for this change This is a minor change, just change `DCHECK` to warning log. ### What changes are included in this PR? change `DCHECK` to warning log. ### Are these changes tested? no, I don't know how to test this, any idea is welcome. ### Are there any user-facing changes? no * Closes: apache#38117 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
…rning log (apache#38118) ### Rationale for this change This is a minor change, just change `DCHECK` to warning log. ### What changes are included in this PR? change `DCHECK` to warning log. ### Are these changes tested? no, I don't know how to test this, any idea is welcome. ### Are there any user-facing changes? no * Closes: apache#38117 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
This is the case described in #35520 . But I didn't find it when previous meet the bug because I just use release build.
When close file with 10 columns, assume column writer 2 has exception on
Close
, it throw an exception. and the third one is aDictEncoder
, so it wouldDCHECK
failed:Component(s)
C++, Parquet
The text was updated successfully, but these errors were encountered: