GH-38117: [C++][Parquet] Change DictEncoder dtor checking to warning log #38118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
mapleFU
force-pushed
the
minor/parquet-dict-encoder-dtor-warning
branch
from
536bb89
to
9b77ec6
Compare
wgtmac
reviewed
Oct 7, 2023
cpp/src/parquet/encoding.cc
Outdated
| ~DictEncoderImpl() override { | ||
| #ifndef NDEBUG | ||
| if (!buffered_indices_.empty()) { | ||
| ARROW_LOG(WARNING) << "DictEncoderImpl destroyed without flushing or closing"; |
There was a problem hiding this comment.
Suggested change
| ARROW_LOG(WARNING) << "DictEncoderImpl destroyed without flushing or closing"; | |
| ARROW_LOG(WARNING) << "DictEncoderImpl is destroyed without flushing or closing"; |
There was a problem hiding this comment.
IIUC, the behavior has changed under debug mode, which calls abort() in the past.
There was a problem hiding this comment.
The reason is described here: #38117
github-actions
bot
added
awaiting committer review
|
I think we can just remove the check/warning. It does not seem very useful, and other encoders don't have it. |
|
@pitrou removed now. |
|
Oops, I should have changed the PR title before merging... |
|
My bad... So sorry for fotget changing the title. |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 02ad5ae. There were 5 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
…rning log (apache#38118) ### Rationale for this change This is a minor change, just change `DCHECK` to warning log. ### What changes are included in this PR? change `DCHECK` to warning log. ### Are these changes tested? no, I don't know how to test this, any idea is welcome. ### Are there any user-facing changes? no * Closes: apache#38117 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…rning log (apache#38118) ### Rationale for this change This is a minor change, just change `DCHECK` to warning log. ### What changes are included in this PR? change `DCHECK` to warning log. ### Are these changes tested? no, I don't know how to test this, any idea is welcome. ### Are there any user-facing changes? no * Closes: apache#38117 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…rning log (apache#38118) ### Rationale for this change This is a minor change, just change `DCHECK` to warning log. ### What changes are included in this PR? change `DCHECK` to warning log. ### Are these changes tested? no, I don't know how to test this, any idea is welcome. ### Are there any user-facing changes? no * Closes: apache#38117 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This is a minor change, just change
DCHECKto warning log.What changes are included in this PR?
change
DCHECKto warning log.Are these changes tested?
no, I don't know how to test this, any idea is welcome.
Are there any user-facing changes?
no
DictEncoderdtor checking #38117