Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Parquet] TypedColumnReaderImpl::Skip should reuse scratch space #42999

Closed
asfimport opened this issue Oct 25, 2022 · 1 comment
Closed

[C++][Parquet] TypedColumnReaderImpl::Skip should reuse scratch space #42999

asfimport opened this issue Oct 25, 2022 · 1 comment
Labels
Component: C++ Component: Parquet Priority: Minor Type: enhancement
Milestone
11.0.0

Comments

@asfimport
Copy link
Collaborator

asfimport commented Oct 25, 2022 •
edited
Loading

TypedColumnReaderImpl::Skip allocates scratch space on every call. The scratch space is used to read rep/def levels and values and throw them away. The memory allocation slows down the skip based on microbenchmarks. The scratch space can be allocated once and re-used.

Reporter: fatemah / @fatemehp
Assignee: fatemah / @fatemehp

PRs and other links:

Note: This issue was originally created as PARQUET-2204. Please see the migration documentation for further details.
@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
Issue resolved by pull request 14509
#14509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: C++ Component: Parquet Priority: Minor Type: enhancement
Projects
None yet
Milestone
11.0.0
Development

No branches or pull requests
1 participant
@asfimport