Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-34621: [GLib] Don't use "g_strdup(XXX->ToString().c_str())" #34624

Merged
merged 1 commit into from
Mar 17, 2023
Merged

GH-34621: [GLib] Don't use "g_strdup(XXX->ToString().c_str())" #34624

merged 1 commit into from
Mar 17, 2023

Conversation

kou
Copy link
Member

@kou kou commented Mar 17, 2023 •
edited by github-actions bot
Loading

Rationale for this change

Because it reports "object backing the pointer will be destroyed at the end of the full-expression" [-Wdangling-gsl] warning.

What changes are included in this PR?

Create a variable for temporary std::string.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou
apacheGH-34621: [GLib] Don't use "g_strdup(XXX->ToString().c_str())"
c55918e 
Because it reports "object backing the pointer will be destroyed at
the end of the full-expression" [-Wdangling-gsl] warning.
@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #34621 has been automatically assigned in GitHub to PR creator.

kou
kou commented Mar 17, 2023
View reviewed changes
Copy link
Member Author

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 5b4595f into apache:main Mar 17, 2023
@kou kou deleted the glib-dangling-gsl branch March 17, 2023 22:54
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Mar 17, 2023
@ursabot
Copy link

ursabot commented Mar 18, 2023

Benchmark runs are scheduled for baseline = 4b20e70 and contender = 5b4595f. 5b4595f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.33% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.26% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.06% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 5b4595f9 ec2-t3-xlarge-us-east-2
[Finished] 5b4595f9 test-mac-arm
[Finished] 5b4595f9 ursa-i9-9960x
[Finished] 5b4595f9 ursa-thinkcentre-m75q
[Finished] 4b20e70a ec2-t3-xlarge-us-east-2
[Failed] 4b20e70a test-mac-arm
[Finished] 4b20e70a ursa-i9-9960x
[Finished] 4b20e70a ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

rtpsw pushed a commit to rtpsw/arrow that referenced this pull request Mar 27, 2023
@kou @rtpsw
apacheGH-34621: [GLib] Don't use "g_strdup(XXX->ToString().c_str())" (a…
8ca044f 
…pache#34624)

### Rationale for this change

Because it reports "object backing the pointer will be destroyed at the end of the full-expression" [-Wdangling-gsl] warning.

### What changes are included in this PR?

Create a variable for temporary `std::string`. 

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#34621

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting changes Awaiting changes Component: C++ - Gandiva Component: GLib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GLib] dangling-gsl warning with GLib 2.76.0
2 participants
@kou @ursabot