Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-35118: [Format][FlightSQL] More use int32 to refer to 32-bit integers rather than int #35213

Merged
merged 2 commits into from
Apr 18, 2023
Merged

GH-35118: [Format][FlightSQL] More use int32 to refer to 32-bit integers rather than int #35213

merged 2 commits into from
Apr 18, 2023

Conversation

appletreeisyellow
Copy link
Contributor

@appletreeisyellow appletreeisyellow commented Apr 18, 2023 •
edited by github-actions bot
Loading

Rationale for this change

There are more inconsistency of the spec format found -- see details on the original issue #35118. #35120 is the first PR with the same fix.

What changes are included in this PR?

Use int32 to refer to 32-bit integers rather than int

Are these changes tested?

No, only comments are changed

Are there any user-facing changes?

This clarifies a small corner case in the document

@github-actions
Copy link

@github-actions github-actions bot added the awaiting review Awaiting review label Apr 18, 2023
kou
kou reviewed Apr 18, 2023
View reviewed changes
format/FlightSql.proto Outdated
Comment on lines 1069 to 1071
* In case of exact numeric types, this represents the maximum precision.
* In case of string types, this represents the character length.
* In case of datetime data types, this represents the length in characters of the string representation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add 2 spaces indent to corresponding documents too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Updated

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Apr 18, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 18, 2023
kou
kou approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou changed the title GH-35118: [FlightSQL] More use int32 to refer to 32-bit integers rather than int GH-35118: [Format][FlightSQL] More use int32 to refer to 32-bit integers rather than int Apr 18, 2023
@kou kou merged commit d7c5e4c into apache:main Apr 18, 2023
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Apr 18, 2023
@appletreeisyellow appletreeisyellow deleted the chunchun/flightsql-typos-int-CommandGetXdbcTypeInfo branch April 19, 2023 14:21
@ursabot
Copy link

ursabot commented Apr 21, 2023

Benchmark runs are scheduled for baseline = e971cf9 and contender = d7c5e4c. d7c5e4c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️8.16% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.15% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] d7c5e4cf ec2-t3-xlarge-us-east-2
[Failed] d7c5e4cf test-mac-arm
[Finished] d7c5e4cf ursa-i9-9960x
[Finished] d7c5e4cf ursa-thinkcentre-m75q
[Finished] e971cf93 ec2-t3-xlarge-us-east-2
[Failed] e971cf93 test-mac-arm
[Finished] e971cf93 ursa-i9-9960x
[Finished] e971cf93 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Apr 21, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

@alamb alamb mentioned this pull request Apr 24, 2023
Closed
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@appletreeisyellow @liujiacheng777
apacheGH-35118: [Format][FlightSQL] More use int32 to refer to 32-b…
c0bd6ea 
…it integers rather than `int` (apache#35213)

### Rationale for this change

There are more inconsistency of the spec format found  -- see details on the original issue apache#35118. apache#35120 is the first PR with the same fix.

### What changes are included in this PR?

Use `int32` to refer to 32-bit integers rather than `int`

### Are these changes tested?

No, only comments are changed

### Are there any user-facing changes?

This clarifies a small corner case in the document

* Closes: apache#35118

Authored-by: Chunchun <14298407+appletreeisyellow@users.noreply.github.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@appletreeisyellow @ArgusLi
apacheGH-35118: [Format][FlightSQL] More use int32 to refer to 32-b…
aa204da 
…it integers rather than `int` (apache#35213)

### Rationale for this change

There are more inconsistency of the spec format found  -- see details on the original issue apache#35118. apache#35120 is the first PR with the same fix.

### What changes are included in this PR?

Use `int32` to refer to 32-bit integers rather than `int`

### Are these changes tested?

No, only comments are changed

### Are there any user-facing changes?

This clarifies a small corner case in the document

* Closes: apache#35118

Authored-by: Chunchun <14298407+appletreeisyellow@users.noreply.github.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
@appletreeisyellow @rtpsw
apacheGH-35118: [Format][FlightSQL] More use int32 to refer to 32-b…
de25e2a 
…it integers rather than `int` (apache#35213)

### Rationale for this change

There are more inconsistency of the spec format found  -- see details on the original issue apache#35118. apache#35120 is the first PR with the same fix.

### What changes are included in this PR?

Use `int32` to refer to 32-bit integers rather than `int`

### Are these changes tested?

No, only comments are changed

### Are there any user-facing changes?

This clarifies a small corner case in the document

* Closes: apache#35118

Authored-by: Chunchun <14298407+appletreeisyellow@users.noreply.github.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

Assignees
No one assigned
Labels
awaiting merge Awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Format][FlightSQL] Spec refers to "int" type (which seems Java specific) rather than "int32"
3 participants
@appletreeisyellow @ursabot @kou