Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-37308: [C++][Docs] Change name for CPP tutorial and minor fixes to the job #37311

Merged
merged 5 commits into from
Aug 25, 2023
Merged

GH-37308: [C++][Docs] Change name for CPP tutorial and minor fixes to the job #37311

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
53366ef
GH-37308: [C++][Doc] Change name for CPP tutorial and minor fixes to …
raulcd Aug 22, 2023
6d76b2d
Fix lint
raulcd Aug 22, 2023
99621ca
Remove unnecessary find_packages and add ARROW_INSTALL_DIR options
raulcd Aug 23, 2023
62d9e7f
Update cpp/examples/tutorial_examples/CMakeLists.txt
raulcd Aug 24, 2023
bd1320d
Add Arrow install to rpath
raulcd Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions cpp/examples/tutorial_examples/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ find_package(Arrow REQUIRED)

get_filename_component(ARROW_CONFIG_PATH ${Arrow_CONFIG} DIRECTORY)
find_package(Parquet REQUIRED HINTS ${ARROW_CONFIG_PATH})
find_package(ArrowAcero REQUIRED HINTS ${ARROW_CONFIG_PATH})
find_package(ArrowDataset REQUIRED HINTS ${ARROW_CONFIG_PATH})
raulcd marked this conversation as resolved.
Show resolved Hide resolved
raulcd marked this conversation as resolved.
Show resolved Hide resolved

set(CMAKE_CXX_STANDARD 17)
Expand All @@ -44,5 +45,7 @@ add_executable(compute_example compute_example.cc)
target_link_libraries(compute_example PRIVATE Arrow::arrow_shared)

add_executable(dataset_example dataset_example.cc)
target_link_libraries(dataset_example PRIVATE Arrow::arrow_shared Parquet::parquet_shared
ArrowDataset::arrow_dataset_shared)
target_link_libraries(dataset_example
PRIVATE Arrow::arrow_shared Parquet::parquet_shared
ArrowAcero::arrow_acero_shared
ArrowDataset::arrow_dataset_shared)
raulcd marked this conversation as resolved.
Show resolved Hide resolved
1 change: 1 addition & 0 deletions cpp/examples/tutorial_examples/dataset_example.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include <parquet/arrow/reader.h>
#include <parquet/arrow/writer.h>

#include <unistd.h>
#include <iostream>
// (Doc section: Includes)

Expand Down
2 changes: 2 additions & 0 deletions cpp/examples/tutorial_examples/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ echo "== Running example project"
echo "=="
echo

export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/usr/local/lib
raulcd marked this conversation as resolved.
Show resolved Hide resolved

${EXAMPLE_BUILD_DIR}/arrow_example
${EXAMPLE_BUILD_DIR}/compute_example
${EXAMPLE_BUILD_DIR}/file_access_example
Expand Down
2 changes: 1 addition & 1 deletion dev/tasks/tasks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1625,7 +1625,7 @@ tasks:
run: {{ kind }}
{% endfor %}

cpp-tutorial-example:
example-cpp-tutorial:
ci: github
template: cpp-examples/github.linux.yml
params:
Expand Down