GH-43519: [Python] Set up wheel building for Python 3.13 #43539
Conversation
lysnikolaou
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
|
|
|
@github-actions crossbow submit -g wheel |
github-actions
bot
added
awaiting changes
This comment was marked as outdated.
This comment was marked as outdated.
|
@lysnikolaou thanks for the PR! Looking at the manylinux wheel builds, that is failing for Python 3.13. While it is failing in the test step (about a docker image for 3.13 no being found, haven't yet looked in detail there), it's actually already failing to correctly build a py 3.13 wheel in the build step, because in practice it is building for Python 3.8 ( The docker image is based on the pypa images, but that is currently pinned to a version of earlier this year: Line 1098 in 66cb749 That might need to be updated to a recent date (the latest builds in the pypa repo should include Python 3.13 I think). The last time this was updated: #39944 |
|
@github-actions crossbow submit test-conda-python-3.13 |
|
Revision: ed4e9d1 Submitted crossbow builds: ursacomputing/crossbow @ actions-404143b223
|
dev/tasks/tasks.yml
Outdated
| {% for python_version in ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"] %} | ||
| test-conda-python-{{ python_version }}: |
There was a problem hiding this comment.
I assume a conda build testing 3.13 will not yet work since conda-forge does not yet have Python 3.13. So maybe this change can be left out for now.
Also for a free-threaded variant, setting this up would not just work like this because then we need to install python from a custom channel? (https://py-free-threading.github.io/installing_cpython/#conda) But even then I am not sure if all other dependencies would then already have packages compatible with that python version?
There was a problem hiding this comment.
That's true. I removed 3.13 for now. Maybe it can be added later, when conda-forge does have a 3.13 version.
github-actions
bot
added
awaiting change review
|
Thanks for the review @jorisvandenbossche!
Yes, I missed those changes in the 3.12 PR. Just pushed a fix for that. |
|
@github-actions crossbow submit wheel-manylinux-* |
This comment was marked as outdated.
This comment was marked as outdated.
|
The Mac failures are because of another issue (the py3.13 builds are failing with the same error as the others) -> #43416. The windows failures seems related though ("Unable to resolve dependency 'python3 (= 3.13.0-rc1)'.") |
|
I missed the comment about update |
|
@github-actions crossbow submit wheel-windows-* |
This comment was marked as outdated.
This comment was marked as outdated.
|
The manylinux one is still failing with Maybe the |
I see those Azurite-related errors from time to time, they seem entirely random to me :-/ |
Done! Is this ready to be merged? |
|
I'll file a separate PR for the "Dev / Lint" issues. Edit: done in #43710 |
|
For the record, the Azurite-related CI failures should be unrelated: #43702 |
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
|
@github-actions crossbow submit cp313 |
|
Revision: e12e2f5 Submitted crossbow builds: ursacomputing/crossbow @ actions-31c3bf8997
|
|
Not sure why |
And now it is also green after restarting it. |
|
NumPy 2.1.0 is released, so will update the requirements to use that version specifically. |
|
@github-actions crossbow submit cp313 |
|
Revision: 747a630 Submitted crossbow builds: ursacomputing/crossbow @ actions-b98b471e60
|
github-actions
bot
added
awaiting changes
|
Feel free to merge @jorisvandenbossche ! |
|
Thanks @lysnikolaou! |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 3e9384b. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 13 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…e#43539) ### Rationale for this change Like apache#43519 mentionies, now that the first `rc` is out, it's probably time to add CI coverage for Python 3.13 (and also start building wheels). ### What changes are included in this PR? I'm fairly new to the build/CI processes of the project, but I tried to follow the same template as apache#37901. I'll follow up afterwards with adding CI coverage for the free-threaded build as well. * GitHub Issue: apache#43519 Lead-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com> Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Rationale for this change
Like #43519 mentionies, now that the first
rcis out, it's probably time to add CI coverage for Python 3.13 (and also start building wheels).What changes are included in this PR?
I'm fairly new to the build/CI processes of the project, but I tried to follow the same template as #37901. I'll follow up afterwards with adding CI coverage for the free-threaded build as well.