MINOR: [CI] Fix ubuntu-lint to not install into system Python #43710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, ubuntu-lint would install its Python dependencies directly into the system Python, which can fail depending on existing system Python packages. See example here: https://github.com/apache/arrow/actions/runs/10400929007/job/28802420047?pr=43539 where pip's dependency resolution fails with the following error message: ``` packaging.version.InvalidVersion: Invalid version: '2013-02-16' ``` Instead, this PR switches to use a virtual environment, guaranteeing that we're not interfering with the system Python and that we're not bound by already installed Python packages.
pitrou
force-pushed
the
minor-lint-venv
branch
from
42732ad
to
f2ef537
Compare
pitrou
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit a50ad42. There were 2 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 129 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Currently, the
ubuntu-lintDocker build would install its Python dependencies directly into the system Python, which can fail depending on existing system Python packages.See example here:
https://github.com/apache/arrow/actions/runs/10400929007/job/28802420047?pr=43539 where pip's dependency resolution fails with the following error message:
What changes are included in this PR?
This PR switches to use a virtual environment, guaranteeing that we're not interfering with the system Python and that we're not bound by already installed Python packages.
Are these changes tested?
By CI.
Are there any user-facing changes?
No.