ARROW-8808: [Rust] Fix divide by zero error in builder #7186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxburke had already picked this up in #7159 (https://github.com/apache/arrow/pull/7159/files#diff-f2e30b8a413036fbb623c52d0ffd519dR723). Perhaps we could port the unit test there, and fix this as part of that PR? |
|
Thanks, I hadn't seen that. It might be faster to get this one merged since it is small. It looks like there are no reviews yet on #7159. I'm fine either way, but would like to unblock integration testing as much as possible. |
@andygrove may you please rebase so we can merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix divide by zero error in one of the builders. This bug was exposed by the integration tests.