Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-8854: [Rust] [Integration Testing] Standardize error handling #7219

Closed
wants to merge 3 commits into from
Closed

ARROW-8854: [Rust] [Integration Testing] Standardize error handling #7219

wants to merge 3 commits into from

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented May 19, 2020 •
edited
Loading

With these changes, I can now see why tests are failing, and also all test failures are now being detected.

This also adds partial support for DataType::Null.

Current status:

################# FAILURES #################
FAILED TEST: primitive Java producing,  Rust consuming

FAILED TEST: primitive_zerolength Java producing,  Rust consuming

FAILED TEST: null Java producing,  Rust consuming

FAILED TEST: null_trivial Java producing,  Rust consuming

FAILED TEST: datetime Java producing,  Rust consuming

FAILED TEST: null Rust producing,  Java consuming

FAILED TEST: null_trivial Rust producing,  Java consuming

FAILED TEST: datetime Rust producing,  Java consuming

FAILED TEST: primitive_large_offsets Rust producing,  Rust consuming

FAILED TEST: null Rust producing,  Rust consuming

FAILED TEST: null_trivial Rust producing,  Rust consuming

FAILED TEST: datetime Rust producing,  Rust consuming

12 failures

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-8854

andygrove
andygrove commented May 19, 2020
View reviewed changes
rust/integration-testing/src/bin/arrow-json-integration-test.rs
@@ -68,24 +69,19 @@ fn main() {
.value_of("json")
.expect("must provide path to json file");
let mode = matches.value_of("mode").unwrap();
let verbose = matches.value_of("verbose").is_some();
let verbose = true; //matches.value_of("verbose").is_some();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find a way to specify this when invoking archery, so hard-coded it for now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

archery --quiet, RustTester should receive a quiet: Bool via kwargs somehwere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed https://issues.apache.org/jira/browse/ARROW-8859 to resolve this as a follow on item

@andygrove andygrove mentioned this pull request May 19, 2020
Closed
@andygrove
Copy link
Member Author

@paddyhoran @nevi-me PTAL when you can

@andygrove andygrove closed this in 11a20bf May 20, 2020
@asfimport asfimport mentioned this pull request May 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsaintjacques fsaintjacques fsaintjacques left review comments

@paddyhoran paddyhoran Awaiting requested review from paddyhoran

@nevi-me nevi-me Awaiting requested review from nevi-me

Assignees
No one assigned
Labels
Component: Rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andygrove @fsaintjacques