ARROW-9762: [Rust] [DataFusion] ExecutionContext::sql now returns DataFrame #8027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Aug 23, 2020
|
Well, thank you to @andygrove , that took the initiative and did the hard work! |
andygrove
pushed a commit
that referenced
this pull request
Sep 1, 2020
This fixes an error I saw in the Datafusion CLI. Running `CREATE EXTERNAL TABLE` errors with `"Unsupported logical plan variant"`
Before this PR, you can't make an external table via the CLI:
```
> create external table test(c1 boolean) stored as CSV location '/tmp/foo';
General("Unsupported logical plan variant")
>
```
After this PR:
```
> create external table test(c1 boolean) stored as CSV location '/tmp/foo';
0 rows in set. Query took 0 seconds.
>
```
Other changes:
* Made the list of unsupported plan nodes explicit in the planer
* Added a test for this behavior.
I think this error was introduced in #8027 which started (rightly) to treat all execution plans in a uniform way and do less special casing. FYI @andygrove
Closes #8083 from alamb/alamb/ARROW-9889-create-table
Authored-by: alamb <andrew@nerdnetworks.org>
Signed-off-by: Andy Grove <andygrove73@gmail.com>
emkornfield
pushed a commit
to emkornfield/arrow
that referenced
this pull request
Oct 16, 2020
…aFrame I need this change so that I can have Ballista use the DataFusion DataFrame trait and start testing the extension points for the physical planner. Closes apache#8027 from andygrove/ARROW-9762 Authored-by: Andy Grove <andygrove73@gmail.com> Signed-off-by: Andy Grove <andygrove73@gmail.com>
emkornfield
pushed a commit
to emkornfield/arrow
that referenced
this pull request
Oct 16, 2020
This fixes an error I saw in the Datafusion CLI. Running `CREATE EXTERNAL TABLE` errors with `"Unsupported logical plan variant"`
Before this PR, you can't make an external table via the CLI:
```
> create external table test(c1 boolean) stored as CSV location '/tmp/foo';
General("Unsupported logical plan variant")
>
```
After this PR:
```
> create external table test(c1 boolean) stored as CSV location '/tmp/foo';
0 rows in set. Query took 0 seconds.
>
```
Other changes:
* Made the list of unsupported plan nodes explicit in the planer
* Added a test for this behavior.
I think this error was introduced in apache#8027 which started (rightly) to treat all execution plans in a uniform way and do less special casing. FYI @andygrove
Closes apache#8083 from alamb/alamb/ARROW-9889-create-table
Authored-by: alamb <andrew@nerdnetworks.org>
Signed-off-by: Andy Grove <andygrove73@gmail.com>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
…aFrame I need this change so that I can have Ballista use the DataFusion DataFrame trait and start testing the extension points for the physical planner. Closes apache#8027 from andygrove/ARROW-9762 Authored-by: Andy Grove <andygrove73@gmail.com> Signed-off-by: Andy Grove <andygrove73@gmail.com>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
This fixes an error I saw in the Datafusion CLI. Running `CREATE EXTERNAL TABLE` errors with `"Unsupported logical plan variant"`
Before this PR, you can't make an external table via the CLI:
```
> create external table test(c1 boolean) stored as CSV location '/tmp/foo';
General("Unsupported logical plan variant")
>
```
After this PR:
```
> create external table test(c1 boolean) stored as CSV location '/tmp/foo';
0 rows in set. Query took 0 seconds.
>
```
Other changes:
* Made the list of unsupported plan nodes explicit in the planer
* Added a test for this behavior.
I think this error was introduced in apache#8027 which started (rightly) to treat all execution plans in a uniform way and do less special casing. FYI @andygrove
Closes apache#8083 from alamb/alamb/ARROW-9889-create-table
Authored-by: alamb <andrew@nerdnetworks.org>
Signed-off-by: Andy Grove <andygrove73@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need this change so that I can have Ballista use the DataFusion DataFrame trait and start testing the extension points for the physical planner.