ARROW-9889: [Rust][DataFusion] Implement physical plan for EmptyRelation #8083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Aug 31, 2020
| @@ -44,7 +44,7 @@ pub struct ExplainExec { | |||
| } | |||
|
|
|||
| impl ExplainExec { | |||
| /// Create a new MergeExec | |||
| /// Create a new ExplainExec | |||
There was a problem hiding this comment.
I snuck this comment fix in -- I can remove it if people prefer.
| @@ -278,6 +278,9 @@ impl DefaultPhysicalPlanner { | |||
| ctx_state.config.concurrency, | |||
| )?)) | |||
| } | |||
| LogicalPlan::EmptyRelation { schema } => { | |||
There was a problem hiding this comment.
this is the actual fix
| @@ -318,12 +330,9 @@ impl DefaultPhysicalPlanner { | |||
| format!("{:#?}", input), | |||
| )); | |||
| } | |||
| let schema_ref = Arc::new((**schema).clone()); | |||
| let schema_ref = Arc::new(schema.as_ref().clone()); | |||
There was a problem hiding this comment.
this ** bothered me, so I switched to the different syntax. It has no intended behavior change
There was a problem hiding this comment.
I prefer to use idiomatic [language being written]. These changes are very welcoming from my side.
|
|
||
| // Mimic the CLI and execute the resulting plan -- even though it | ||
| // is effectively a no-op (returns zero rows) | ||
| let results = df.collect().expect("Executing CREATE EXTERNAL TABLE"); |
There was a problem hiding this comment.
Prior to the code change, the tests now fail in the same way as reported in ARROW-9889:
---- csv_query_create_external_table stdout ----
thread 'csv_query_create_external_table' panicked at 'Executing CREATE EXTERNAL TABLE: General("Unsupported logical plan variant")', datafusion/tests/sql.rs:526:19
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
andygrove
approved these changes
Aug 31, 2020
jorgecarleitao
approved these changes
Aug 31, 2020
alamb
force-pushed
the
alamb/ARROW-9889-create-table
branch
from
f6bc35f
to
e2da41d
Compare
|
Rebased |
emkornfield
pushed a commit
to emkornfield/arrow
that referenced
this pull request
Oct 16, 2020
This fixes an error I saw in the Datafusion CLI. Running `CREATE EXTERNAL TABLE` errors with `"Unsupported logical plan variant"`
Before this PR, you can't make an external table via the CLI:
```
> create external table test(c1 boolean) stored as CSV location '/tmp/foo';
General("Unsupported logical plan variant")
>
```
After this PR:
```
> create external table test(c1 boolean) stored as CSV location '/tmp/foo';
0 rows in set. Query took 0 seconds.
>
```
Other changes:
* Made the list of unsupported plan nodes explicit in the planer
* Added a test for this behavior.
I think this error was introduced in apache#8027 which started (rightly) to treat all execution plans in a uniform way and do less special casing. FYI @andygrove
Closes apache#8083 from alamb/alamb/ARROW-9889-create-table
Authored-by: alamb <andrew@nerdnetworks.org>
Signed-off-by: Andy Grove <andygrove73@gmail.com>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
This fixes an error I saw in the Datafusion CLI. Running `CREATE EXTERNAL TABLE` errors with `"Unsupported logical plan variant"`
Before this PR, you can't make an external table via the CLI:
```
> create external table test(c1 boolean) stored as CSV location '/tmp/foo';
General("Unsupported logical plan variant")
>
```
After this PR:
```
> create external table test(c1 boolean) stored as CSV location '/tmp/foo';
0 rows in set. Query took 0 seconds.
>
```
Other changes:
* Made the list of unsupported plan nodes explicit in the planer
* Added a test for this behavior.
I think this error was introduced in apache#8027 which started (rightly) to treat all execution plans in a uniform way and do less special casing. FYI @andygrove
Closes apache#8083 from alamb/alamb/ARROW-9889-create-table
Authored-by: alamb <andrew@nerdnetworks.org>
Signed-off-by: Andy Grove <andygrove73@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error I saw in the Datafusion CLI. Running
CREATE EXTERNAL TABLEerrors with"Unsupported logical plan variant"Before this PR, you can't make an external table via the CLI:
After this PR:
Other changes:
I think this error was introduced in #8027 which started (rightly) to treat all execution plans in a uniform way and do less special casing. FYI @andygrove