Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-11054: [Rust] [DataFusion] Move to sqlparser 0.7.0 #9037

Closed
wants to merge 2 commits into from
Closed

ARROW-11054: [Rust] [DataFusion] Move to sqlparser 0.7.0 #9037

wants to merge 2 commits into from

Conversation

ovr
Copy link
Contributor

@ovr ovr commented Dec 28, 2020

Hello!

Thanks

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-11054

andygrove
andygrove approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ovr

@ovr
Copy link
Contributor Author

ovr commented Dec 28, 2020 •
edited

@andygrove I am still working on it, planning to finish today/tomorrow. I will mark this PR to ready for review after it.

@ovr ovr marked this pull request as ready for review December 29, 2020 00:01
@ovr
Copy link
Contributor Author

ovr commented Dec 29, 2020

I finished, CI passed, I think PR is now ready for review.

Thanks

cC @andygrove

Dandandan
Dandandan approved these changes Dec 29, 2020
View reviewed changes
Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😎 looks great @ovr !

@alamb
Copy link
Contributor

alamb commented Dec 31, 2020

The full set of Rust CI tests did not run on this PR :(

Can you please rebase this PR against apache/master to pick up the changes in #9056 so that they do?

I apologize for the inconvenience.

alamb
alamb approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks @ovr

@codecov-io
Copy link

Codecov Report

Merging #9037 (81141a8) into master (cf0ef79) will decrease coverage by 0.02%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9037      +/-   ##
==========================================
- Coverage   82.64%   82.61%   -0.03%     
==========================================
  Files         202      202              
  Lines       50044    50052       +8     
==========================================
- Hits        41358    41351       -7     
- Misses       8686     8701      +15
Impacted Files Coverage Δ
rust/datafusion/src/sql/parser.rs 82.35% <36.36%> (-4.53%) ⬇️
rust/datafusion/src/sql/planner.rs 83.97% <64.00%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf0ef79...81141a8. Read the comment docs.

@alamb alamb closed this in dd5fe70 Dec 31, 2020
@alamb
Copy link
Contributor

alamb commented Dec 31, 2020

Thanks again @ovr

@ovr ovr deleted the sqlparser-0.7 branch January 9, 2021 10:01
GeorgeAp pushed a commit to sirensolutions/arrow that referenced this pull request Jun 7, 2021
@ovr @GeorgeAp
ARROW-11054: [Rust] [DataFusion] Move to sqlparser 0.7.0
281eb75 
Hello!

Thanks

Closes apache#9037 from ovr/sqlparser-0.7

Authored-by: Dmitry Patsura <zaets28rus@gmail.com>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
@asfimport asfimport mentioned this pull request Dec 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dandandan Dandandan Dandandan approved these changes

@alamb alamb alamb approved these changes

@andygrove andygrove andygrove approved these changes

Assignees
No one assigned
Labels
Component: Rust - DataFusion Component: Rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ovr @alamb @codecov-io @Dandandan @andygrove