ARROW-11435: [Datafusion] allow creating ParquetPartition from external crate, make combine_filters public #9369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houqp
force-pushed
the
qp_parquetpartition
branch
from
96485ec
to
c46ff83
Compare
Codecov Report
@@ Coverage Diff @@
## master #9369 +/- ##
==========================================
- Coverage 81.94% 81.94% -0.01%
==========================================
Files 231 231
Lines 53374 53375 +1
==========================================
- Hits 43739 43738 -1
- Misses 9635 9637 +2
Continue to review full report at Codecov.
|
…al crate also move combine_filters from physical_plan/parquet.rs into logical_plan/expr.rs.
houqp
force-pushed
the
qp_parquetpartition
branch
from
c46ff83
to
f9a2342
Compare
andygrove
approved these changes
Jan 30, 2021
alamb
changed the title
alamb
approved these changes
Jan 31, 2021
|
@andygrove @alamb gentle ping to help with the merge if everything looks good on your end ;P |
|
Looks good to me -- I'll merge it in! |
nevi-me
pushed a commit
to nevi-me/arrow
that referenced
this pull request
Feb 13, 2021
…al crate, make combine_filters public Without this, it's not possible to create TableProvider in external crate that tagets parquet format because `ParquetExec::new` takes `ParquetPartition` as argument. Closes apache#9369 from houqp/qp_parquetpartition Authored-by: Qingping Hou <qph@scribd.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
…al crate, make combine_filters public Without this, it's not possible to create TableProvider in external crate that tagets parquet format because `ParquetExec::new` takes `ParquetPartition` as argument. Closes apache#9369 from houqp/qp_parquetpartition Authored-by: Qingping Hou <qph@scribd.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
…al crate, make combine_filters public Without this, it's not possible to create TableProvider in external crate that tagets parquet format because `ParquetExec::new` takes `ParquetPartition` as argument. Closes apache#9369 from houqp/qp_parquetpartition Authored-by: Qingping Hou <qph@scribd.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, it's not possible to create TableProvider in external crate that tagets parquet format because
ParquetExec::newtakesParquetPartitionas argument.