AVRO-2813: Add cppcheck as a C++ linter (#862)

apache · Apr 26, 2020 · f56cafb · f56cafb
1 parent b6f4970
commit f56cafb
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/build.sh b/build.sh
@@ -88,7 +88,7 @@ do
       (cd lang/py && ./build.sh lint test)
       (cd lang/py3 && ./build.sh lint test)
       (cd lang/c; ./build.sh test)
-      (cd lang/c++; ./build.sh test)
+      (cd lang/c++; ./build.sh lint test)
       (cd lang/csharp; ./build.sh test)
       (cd lang/js; ./build.sh lint test)
       (cd lang/ruby; ./build.sh lint test)

diff --git a/lang/c++/build.sh b/lang/c++/build.sh
@@ -77,7 +77,9 @@ do
 
 case "$target" in
   lint)
-    echo 'This is a stub where someone can provide linting.'
+    # some versions of cppcheck seem to require an explicit
+    # "--error-exitcode" option to return non-zero code
+    cppcheck --error-exitcode=1 --inline-suppr -f -q -x c++ .
     ;;
 
   test)

diff --git a/lang/c++/impl/Zigzag.cc b/lang/c++/impl/Zigzag.cc
@@ -24,6 +24,7 @@ namespace avro {
 uint64_t
 encodeZigzag64(int64_t input)
 {
+    // cppcheck-suppress shiftTooManyBitsSigned
     return ((input << 1) ^ (input >> 63));
 }
 
@@ -36,6 +37,7 @@ decodeZigzag64(uint64_t input)
 uint32_t
 encodeZigzag32(int32_t input)
 {
+    // cppcheck-suppress shiftTooManyBitsSigned
     return ((input << 1) ^ (input >> 31));
 }
 

diff --git a/share/docker/Dockerfile b/share/docker/Dockerfile
@@ -34,6 +34,7 @@ RUN apt-get -qqy update \
                                                  bzip2 \
                                                  bundler \
                                                  cmake \
+                                                 cppcheck \
                                                  curl \
                                                  doxygen \
                                                  flex \