Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3370: Allow complex types as names #1533

Merged

Conversation

RyanSkraba
Copy link
Contributor

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@netlify
Copy link

netlify bot commented Feb 10, 2022

❌ Deploy Preview for avro-website-preview failed.

🔨 Explore the source changes: 0e38bbd

🔍 Inspect the deploy log: https://app.netlify.com/sites/avro-website-preview/deploys/62057c3dee33040007481e8a

@RyanSkraba
Copy link
Contributor Author

Note -- we haven't really come to a consensus whether this is the right thing to do! https://lists.apache.org/thread/0wmgyx6z69gy07lvj9ndko75752b8cn2

@RyanSkraba RyanSkraba force-pushed the rskraba/AVRO-3370-python-permissive branch from 4c5d61b to 0e38bbd Compare February 10, 2022 20:57
@RyanSkraba RyanSkraba merged commit f4725ca into apache:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants