Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3499 Remove unnecessary suppressions #1655

Closed
wants to merge 26 commits into from

Conversation

KyleSchoonover
Copy link
Contributor

Jira

Tests

  • My PR does not need testing for this extremely good reason: non functional change

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@github-actions github-actions bot added the C# label Apr 20, 2022
@martin-g
Copy link
Member

@KyleSchoonover how do you create the new branches for PRs ?
It is strange that a fresh PR has 20 commits like "Merge branch 'apache:master' into master".
Could you please re-create this PR ? I expect to see only commits related to the PR itself.

@KyleSchoonover KyleSchoonover deleted the AVRO-3499 branch April 20, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants