AVRO-2118-license-headers #267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gszadovszky
reviewed
Dec 14, 2017
| @@ -1,4 +1,18 @@ | |||
|
|
|||
| /* | |||
| * Copyright 2015 The Apache Software Foundation. | |||
There was a problem hiding this comment.
I think, the copyright + year part is not necessary. Most of the other java files (e.g. org.apache.avro.Schema) do not contain it.
There was a problem hiding this comment.
Should I remove it?
There was a problem hiding this comment.
Yes please. Just make it the same as all other .java files.
spacharya
approved these changes
Dec 14, 2017
There was a problem hiding this comment.
No additional comments apart from what @gszadovszky has mentioned.
Submit after changes are made
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the license headers.