AVRO-3938: [Java] Add null guards for Schema.Parser #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Schema.Parser` class has a private final property `validate`. This means that the value provided to its constructor is saved and cannot be changed at a later time. However, if `null` is passed as `validate`, then it is bound to throw a `NullPointerException` at an arbitrary time. This commit adds a fail-fast guard against `null` to prevent this.
martin-g
reviewed
Feb 15, 2024
|
@martin-g How do you think the test should be modified? I can't think of how to verify the change and honestly don't think one is strictly needed here. |
Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
|
IMO the test should verify that the Parser behaves the same way as when |
|
@martin-g Just pushed a new test case involving an empty string as a name. PTAL. |
martin-g
approved these changes
Feb 15, 2024
|
@martin-g Seems the PR passed the checks. Could you checki if this PR could be merged by any chance? Thanks. |
|
Thank you, @pingpingy1 ! |
RanbirK
pushed a commit
to RanbirK/avro
that referenced
this pull request
May 13, 2024
* AVRO-3938: Add null guards for Schema.Parser The `Schema.Parser` class has a private final property `validate`. This means that the value provided to its constructor is saved and cannot be changed at a later time. However, if `null` is passed as `validate`, then it is bound to throw a `NullPointerException` at an arbitrary time. This commit adds a fail-fast guard against `null` to prevent this. * Apply suggestions from code review Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com> * Modify test case --------- Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request provides a fail-fast guard against the
private finalpropertySchema.Parser.validate, implementing AVRO-3938.Verifying this change
This change added the test
TestSchema.testParserNullValidate.Documentation