Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVRO-3938: [Java] Add null guards for Schema.Parser #2738

Merged
merged 3 commits into from
Feb 21, 2024
Merged

AVRO-3938: [Java] Add null guards for Schema.Parser #2738

merged 3 commits into from
Feb 21, 2024

Commits on Feb 15, 2024

  1. AVRO-3938: Add null guards for Schema.Parser 

    The `Schema.Parser` class has a private final property `validate`.
This means that the value provided to its constructor is saved and
cannot be changed at a later time.
However, if `null` is passed as `validate`, then it is bound to throw a
`NullPointerException` at an arbitrary time.
This commit adds a fail-fast guard against `null` to prevent this.
    @pingpingy1
    pingpingy1 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    78c2d74 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
    @pingpingy1 @martin-g
    pingpingy1 and martin-g committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    37c1518 View commit details
    Browse the repository at this point in the history

  3. Modify test case

    @pingpingy1
    pingpingy1 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    e2088eb View commit details
    Browse the repository at this point in the history