Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVRO-1837: Logical Types: date, time & timestamp #545

Merged
merged 3 commits into from
Jun 19, 2019
Merged

AVRO-1837: Logical Types: date, time & timestamp #545

merged 3 commits into from
Jun 19, 2019

Conversation

kojiromike
Copy link
Contributor

This is a third-party rebase of #207.

closes #207

@kojiromike kojiromike changed the title AVRO-1837 Logical Types: date, time & timestamp AVRO-1837: Logical Types: date, time & timestamp Jun 17, 2019
@kojiromike
Copy link
Contributor Author

@Fokko This is a rebase of #207. The conflicts were from the subsequent merge of #82. This melds the two sets of logical type handling together.

Fokko
Fokko approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @kojiromike LGTM

@Fokko Fokko merged commit 81605f7 into apache:master Jun 19, 2019
Fokko pushed a commit that referenced this pull request Jun 19, 2019
@kojiromike @Fokko
AVRO-1837: Logical Types: date, time & timestamp (#545)
349d35c 
* AVRO-1837: Logicaltype support for date, time and timestamp

* AVRO-1837: add timezones.py file

* AVRO-1837: fix init file in py

closes #207
closes #82

(cherry picked from commit 81605f7)
@kojiromike kojiromike deleted the avro-1837/time-logical-type branch June 19, 2019 14:04
@abrarsheikh
Copy link

thanks for picking this up

Fokko referenced this pull request in Fokko/avro Aug 14, 2019
@kojiromike @Fokko
AVRO-1837: Logical Types: date, time & timestamp (#545)
a3ac3d8 
* AVRO-1837: Logicaltype support for date, time and timestamp

* AVRO-1837: add timezones.py file

* AVRO-1837: fix init file in py

closes #207
closes #82

(cherry picked from commit 81605f7)
@Fokko
Copy link
Contributor

Fokko commented Aug 14, 2019

This has been backported to the 1.9 branch as well.

@mikepk mikepk mentioned this pull request Feb 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fokko Fokko Fokko approved these changes

Assignees
No one assigned
Labels
Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kojiromike @abrarsheikh @Fokko