Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-2676: Document that lang/py3 will be deprecated #763

Merged
merged 2 commits into from
Jan 11, 2020

Conversation

sekikn
Copy link
Contributor

@sekikn sekikn commented Jan 9, 2020

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

No additional test, since it's a documentation fix. Instead, I ran ant in the doc directory and confirmed the documents were generated as expected.

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

Copy link
Contributor

@kojiromike kojiromike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't quite supposed to be api compatible. For whatever reason, avro-python3 is a little different, particularly with capitalizing some names like Parse. But it's mostly API compatible.

@sekikn
Copy link
Contributor Author

sekikn commented Jan 9, 2020

@kojiromike Thanks! Updated the description.

@Fokko
Copy link
Contributor

Fokko commented Jan 9, 2020

Restarted the CI, seems like an unrelated issue

@kojiromike kojiromike merged commit 9c54c3d into apache:master Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants