AVRO-2943 improve GenericRecord MAP type comparison #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make GenericRecord comparison handle String vs Utf8 for MAP type This mirrors what was already previously done for Schema.type.STRING Adds the following new unit tests: - org.apache.avro.generic.TestGenericData.testMapKeyEquals - org.apache.avro.generic.TestGenericData.testMapValuesEquals N.B. We should also consider doing the same for Schema.type.ARRAY https://issues.apache.org/jira/browse/AVRO-2943
frankgrimes97
added a commit
to frankgrimes97/avro
that referenced
this pull request
Mar 9, 2023
Improves clarify of what the tests are actually verifying. Follow-up to: apache#974 https://issues.apache.org/jira/browse/AVRO-2943
frankgrimes97
added a commit
to frankgrimes97/avro
that referenced
this pull request
Mar 10, 2023
GenericRecord comparison already handles String vs Utf8 for ARRAY elements. This just adds a unit test to explicitly verify the current correct behaviour. Also renamed GenericData String/Utf8 MAP unit tests which were added on apache#974 to improve clarity on what those tests are actually verifying. https://issues.apache.org/jira/browse/AVRO-2943
RyanSkraba
pushed a commit
that referenced
this pull request
Mar 13, 2023
) GenericRecord comparison already handles String vs Utf8 for ARRAY elements. This just adds a unit test to explicitly verify the current correct behaviour. Also renamed GenericData String/Utf8 MAP unit tests which were added on #974 to improve clarity on what those tests are actually verifying. https://issues.apache.org/jira/browse/AVRO-2943
|
Hello @dkulp ! Should this be cherry-picked to |
|
@RyanSkraba It would be great! |
RyanSkraba
pushed a commit
to RyanSkraba/avro
that referenced
this pull request
Jun 13, 2023
…ache#2137) GenericRecord comparison already handles String vs Utf8 for ARRAY elements. This just adds a unit test to explicitly verify the current correct behaviour. Also renamed GenericData String/Utf8 MAP unit tests which were added on apache#974 to improve clarity on what those tests are actually verifying. https://issues.apache.org/jira/browse/AVRO-2943
RyanSkraba
pushed a commit
that referenced
this pull request
Jun 14, 2023
) GenericRecord comparison already handles String vs Utf8 for ARRAY elements. This just adds a unit test to explicitly verify the current correct behaviour. Also renamed GenericData String/Utf8 MAP unit tests which were added on #974 to improve clarity on what those tests are actually verifying. https://issues.apache.org/jira/browse/AVRO-2943
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make GenericRecord comparison handle String vs Utf8 for MAP type
This mirrors what was already previously done for Schema.type.STRING
Adds the following new unit tests:
N.B.
We should also consider doing the same for Schema.type.ARRAY
https://issues.apache.org/jira/browse/AVRO-2943