Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-2943: Add new GenericData String/Utf8 ARRAY comparison test #2137

Conversation

frankgrimes97
Copy link
Contributor

@github-actions github-actions bot added the Java Pull Requests for Java binding label Mar 9, 2023
Copy link
Contributor

@clesaec clesaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have just one question, ptal

GenericRecord comparison already handles String vs Utf8 for ARRAY elements.
This just adds a unit test to explicitly verify the current correct behaviour.

Also renamed GenericData String/Utf8 MAP unit tests which were added
on apache#974 to improve
clarity on what those tests are actually verifying.

https://issues.apache.org/jira/browse/AVRO-2943
@frankgrimes97 frankgrimes97 force-pushed the feature/AVRO-2943-equals-array-comparison-string-vs-utf8 branch from a397979 to 92cf729 Compare March 10, 2023 17:33
Copy link

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aromanenko-dev
Copy link

@dkulp could you take a look and merge if there are no objections?

@RyanSkraba RyanSkraba changed the title [AVRO-2943] Add new GenericData String/Utf8 ARRAY comparison test AVRO-2943: Add new GenericData String/Utf8 ARRAY comparison test Mar 13, 2023
@RyanSkraba RyanSkraba merged commit 5c0b17d into apache:master Mar 13, 2023
RyanSkraba pushed a commit to RyanSkraba/avro that referenced this pull request Jun 13, 2023
…ache#2137)

GenericRecord comparison already handles String vs Utf8 for ARRAY elements.
This just adds a unit test to explicitly verify the current correct behaviour.

Also renamed GenericData String/Utf8 MAP unit tests which were added
on apache#974 to improve
clarity on what those tests are actually verifying.

https://issues.apache.org/jira/browse/AVRO-2943
RyanSkraba pushed a commit to RyanSkraba/avro that referenced this pull request Jun 14, 2023
…ache#2137)

GenericRecord comparison already handles String vs Utf8 for ARRAY elements.
This just adds a unit test to explicitly verify the current correct behaviour.

Also renamed GenericData String/Utf8 MAP unit tests which were added
on apache#974 to improve
clarity on what those tests are actually verifying.

https://issues.apache.org/jira/browse/AVRO-2943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java Pull Requests for Java binding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants