Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPC-DS: Fix CSV format #28819

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

aromanenko-dev
Copy link
Contributor

Quick fix to make it working with trailing delimiters


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the java label Oct 4, 2023
@aromanenko-dev
Copy link
Contributor Author

R: @mosche

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@mosche
Copy link
Member

mosche commented Oct 4, 2023

👍 lgtm, though spotless is failing. pls apply formatting changes

@aromanenko-dev
Copy link
Contributor Author

Fixed. merging

@aromanenko-dev aromanenko-dev merged commit 0a560fc into apache:master Oct 4, 2023
23 checks passed
@aromanenko-dev aromanenko-dev deleted the tpcds_csvformat_fix branch October 4, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants