Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-115,BEAM-1348] Unify Runner API and Fn API coders #2065

Closed
wants to merge 1 commit into from

Conversation

kennknowles
Copy link
Member

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

Just shares Coder. Its a hack - it is really crufty to have side-by-side int and string registries. But coders need to be by-reference. Options, off the top of my head:

  1. Make everything keyed on int64 (distasteful for debugging, but not horrid).
  2. Make everything keyed on string.
  3. Make Fn API and harness really embrace separate registries by type.
  4. Write 3 lines of conversion code, since sharing this one trivial proto has only unclear benefit, while avoiding a hard dependency is almost always a win.

R: @dhalperi

@asfbot
Copy link

asfbot commented Feb 22, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7675/

Build result: FAILURE

[...truncated 1.05 MB...] at hudson.remoting.UserRequest.perform(UserRequest.java:153) at hudson.remoting.UserRequest.perform(UserRequest.java:50) at hudson.remoting.Request$2.run(Request.java:336) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)Caused by: org.apache.maven.plugin.MojoExecutionException: Dependency problems found at org.apache.maven.plugins.dependency.analyze.AbstractAnalyzeMojo.execute(AbstractAnalyzeMojo.java:261) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 more2017-02-22T03:55:24.192 [ERROR] 2017-02-22T03:55:24.192 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-02-22T03:55:24.192 [ERROR] 2017-02-22T03:55:24.192 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-02-22T03:55:24.192 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException2017-02-22T03:55:24.193 [ERROR] 2017-02-22T03:55:24.193 [ERROR] After correcting the problems, you can resume the build with the command2017-02-22T03:55:24.193 [ERROR] mvn -rf :beam-sdks-java-harnesschannel stoppedSetting status of 3d4aed8 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7675/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 69.287% when pulling 6c5ec75 on kennknowles:fn-api-coders-only into 0d639e6 on apache:master.

@asfbot
Copy link

asfbot commented Feb 22, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7680/
--none--

@kennknowles
Copy link
Member Author

I'm pretty unhappy with the cruftiness of this, so now that I've proposed a few unification possibilities, I'm going to rest easy assuming there won't be any or much sharing. I won't yet collapse and simplify GraphNode since it isn't blocking.

@kennknowles kennknowles deleted the fn-api-coders-only branch March 31, 2017 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants