Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23832] Remove ParquetIO.withSplit #23833

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

aromanenko-dev
Copy link
Contributor

@aromanenko-dev aromanenko-dev commented Oct 25, 2022

Following BEAM-12070 where ParquetIO.withSplit became a default behaviour and taking into account the fact that no related issues were reported in the last several Beam releases (since Beam 2.35.0), we may drop such functionality as it was planned before.

Fixes #23832


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @ahmedabu98 for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@aromanenko-dev
Copy link
Contributor Author

Run Java ParquetIO Performance Test

@aromanenko-dev
Copy link
Contributor Author

Run Spark Runner Tpcds Tests

@aromanenko-dev
Copy link
Contributor Author

R: @mosche
R: @TheNeuralBit

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Member

@mosche mosche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, always great to remove a bunch of old obsolete code 🥇
LGTM 😄

CHANGES.md Outdated Show resolved Hide resolved
Co-authored-by: Moritz Mack <mmack@talend.com>
@mosche mosche merged commit 840d66a into apache:master Oct 26, 2022
@aromanenko-dev aromanenko-dev deleted the 23832_parquetio_remove_withsplit branch October 26, 2022 16:09
Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for following up on this :)

CHANGES.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Remove ParquetIO.withSplit
3 participants