Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-720] Re-enable WindowedWordCountIT on Flink runner in precommit #2662

Closed

Conversation

kennknowles
Copy link
Member

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@jasonkuster
Copy link
Contributor

retest this please

1 similar comment
@jasonkuster
Copy link
Contributor

retest this please

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 876f621 on kennknowles:Flink-WindowedWordCountIT into ** on apache:master**.

@coveralls
Copy link

coveralls commented Apr 29, 2017

Coverage Status

Coverage increased (+22.1%) to 91.918% when pulling e2ebd9e on kennknowles:Flink-WindowedWordCountIT into f5e3f52 on apache:master.

@kennknowles
Copy link
Member Author

R: anyone, trivial

Nice that it just works! CC: @reuvenlax, @aljoscha, @JingsongLi, @iemejia who all had some part in unifying the examples and how FlinkRunner runs them.

Copy link
Member

@lukecwik lukecwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in 87236ce May 1, 2017
@kennknowles kennknowles deleted the Flink-WindowedWordCountIT branch May 26, 2017 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants