[BEAM-2791] Add a test for an event time timer loop in ParDo #3745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgroh
approved these changes
Sep 7, 2017
| @@ -2740,6 +2740,49 @@ public void onTimer(OnTimerContext context) { | |||
| pipeline.run(); | |||
| } | |||
|
|
|||
| @Ignore | |||
| @Test | |||
| @Category({ValidatesRunner.class, UsesStatefulParDo.class}) | |||
There was a problem hiding this comment.
Done, and adding JIRA links to the @Ignore. I'll make tests actually do pass after rebase. Don't recall why they didn't previously, since this is a noop for them. Probably some past flake.
kennknowles
force-pushed
the
timer-loop
branch
from
2a4d086
to
14944e1
Compare
kennknowles
force-pushed
the
timer-loop
branch
from
14944e1
to
4c3bac8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.R: @tgroh adding this test to indicate the issue and link with JIRA, and will try to find time to fix it later.