Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-3598][BEAM-3599][BEAM-3605] Sickbay flaky KinesisIO tests #4605

Merged
merged 1 commit into from Feb 6, 2018

Conversation

kennknowles
Copy link
Member

This sets flaky tests to be ignored. I have opened a thread on the dev list about what to do about KinesisIO now that there are quite a few tests ignored.


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@kennknowles
Copy link
Member Author

retest this please

@kennknowles
Copy link
Member Author

In a cruel twist, the Apex flake hit gradle and Python flaked in its own way.

@kennknowles kennknowles merged commit 2c01ad5 into apache:master Feb 6, 2018
@kennknowles kennknowles deleted the KinesisIO branch July 3, 2018 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants