Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-3598] Sickbay Kinesis ShardReadersPoolTest #4612

Closed
wants to merge 1 commit into from

Conversation

tgroh
Copy link
Member

@tgroh tgroh commented Feb 6, 2018

shouldStopReadersPoolAlsoWhenExceptionsOccurDuringStopping is quite
flaky, due to missing mock interactions.


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

shouldStopReadersPoolAlsoWhenExceptionsOccurDuringStopping is quite
flaky, due to missing mock interactions.
@kennknowles
Copy link
Member

Right back at you: #4605

@tgroh
Copy link
Member Author

tgroh commented Feb 8, 2018

Yeh, got crushed by LIFO review inspections.

GG no re, and whatnot.

@tgroh tgroh closed this Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants