Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-6726] remove duplicate artifact declaration on maven publish #7925

Merged
merged 1 commit into from
Feb 22, 2019

Conversation

adude3141
Copy link
Contributor

This fixes improper configuration in :beam-sdks-java-bom as to not add duplicated artefact declaration.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@adude3141
Copy link
Contributor Author

R: @aaltay

@aaltay
Copy link
Member

aaltay commented Feb 22, 2019

Run Java PreCommit

@aaltay
Copy link
Member

aaltay commented Feb 22, 2019

Do you know why tests are failing?

@adude3141
Copy link
Contributor Author

@aaltay
Copy link
Member

aaltay commented Feb 22, 2019

OK, let's wait for that issue to be resolved.

@kennknowles
Copy link
Member

Green.

@kennknowles
Copy link
Member

I have a question - how can we make this failure happen in our continuous build so it is caught before release time?

@kennknowles
Copy link
Member

Is it just that we have to eliminate the isRelease flag and do all the same things during snapshot releases? The things controlled by -PisRelease, -Ppublishing and -PnoSigning seem like they could be controlled by choosing different gradle targets. WDYT?

@aaltay
Copy link
Member

aaltay commented Feb 22, 2019

I am all for removing all those flags from our build. It does not make sense to me that we have pieces of build code that is only tested at release times.

If that is not feasible (gradle experts to confirm) I would at least suggest having a nightly job to run release process exactly as we ask a release manager to do. Literally a script to follow the release guide.

@aaltay aaltay merged commit 7d11430 into apache:master Feb 22, 2019
@adude3141
Copy link
Contributor Author

+1 for moving as much as possible to our automated (daily) snapshot builds, e.g. https://builds.apache.org/job/beam_Release_NightlySnapshot/

Unfortunately I m not to familiar with beams publish/release process and all these flags. Ideally only difference would be the SNAPSHOT appendix on version (and with that the target repo)

Need to look deeper into this.

aaltay added a commit to aaltay/beam that referenced this pull request Feb 26, 2019
[BEAM-6726] remove duplicate artifact declaration on maven publish
aaltay added a commit that referenced this pull request Feb 26, 2019
Cherry pick PR #7925 #7943 and undo revert #7787 in the release branch
aaltay added a commit that referenced this pull request Feb 26, 2019
@adude3141 adude3141 deleted the BEAM-6726 branch March 10, 2019 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants