-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-6726] remove duplicate artifact declaration on maven publish #7925
Conversation
R: @aaltay |
Run Java PreCommit |
Do you know why tests are failing? |
OK, let's wait for that issue to be resolved. |
Green. |
I have a question - how can we make this failure happen in our continuous build so it is caught before release time? |
Is it just that we have to eliminate the |
I am all for removing all those flags from our build. It does not make sense to me that we have pieces of build code that is only tested at release times. If that is not feasible (gradle experts to confirm) I would at least suggest having a nightly job to run release process exactly as we ask a release manager to do. Literally a script to follow the release guide. |
+1 for moving as much as possible to our automated (daily) snapshot builds, e.g. https://builds.apache.org/job/beam_Release_NightlySnapshot/ Unfortunately I m not to familiar with beams publish/release process and all these flags. Ideally only difference would be the SNAPSHOT appendix on version (and with that the target repo) Need to look deeper into this. |
[BEAM-6726] remove duplicate artifact declaration on maven publish
This fixes improper configuration in :beam-sdks-java-bom as to not add duplicated artefact declaration.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.