-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-7275] ParDoLifeCycleTest: collect lifecycle info for DoFn insta… #8563
Conversation
Run Flink ValidatesRunner |
Run Dataflow ValidatesRunner |
Run Spark ValidatesRunner |
Run Java Flink PortableValidatesRunner Batch |
Run Java Flink PortableValidatesRunner Streaming |
Run Dataflow PortabilityApi ValidatesRunner |
Run Spark ValidatesRunner |
Run Flink ValidatesRunner |
Run Dataflow ValidatesRunner |
Run Spark ValidatesRunner |
Run Java Flink PortableValidatesRunner Batch |
Run Java Flink PortableValidatesRunner Streaming |
Run Dataflow PortabilityApi ValidatesRunner |
retest this please |
Run Spark ValidatesRunner |
Run Spark ValidatesRunner |
Run Dataflow PortabilityApi ValidatesRunner |
Run Java Flink PortableValidatesRunner Batch |
Run Dataflow ValidatesRunner |
Run Flink ValidatesRunner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix.
Thanks @kennknowles. Deleted a leftover commented out line of code as fixup commit. |
…nces
The latest changes done in https://issues.apache.org/jira/browse/BEAM-7197 seem to have caused some flakiness on spark runner, see https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/buildTimeTrend
Of course that static boolean tracking the call to teardown (
beam/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoLifecycleTest.java
Line 290 in 80e2cef
This PR replace this single static var by a map collecting on instances. We expect for every instance which had any lifecycle method invoked that the runner calls teardown.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.