[BEAM-2888] Add the not-yet-fully-designed drain and checkpoint to runner comparison #8576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SUCCESS --none-- |
|
Tagging many authors of other runners to review and potentially fill in details here, since I only know very high level bits. |
xinyuiscool
reviewed
May 14, 2019
| l1: | ||
| l2: | ||
| l3: | ||
| - class: samza |
There was a problem hiding this comment.
For Samza, it's using its native checkpoint capability. Basically checkpoint happens periodically based on user config. The checkpoints are saved in a metadata store or stream, and the states are flushed during checkpointing.
There was a problem hiding this comment.
Can a user save it and then start up the pipeline later?
iemejia
reviewed
May 14, 2019
|
Ping. Any more to add? |
lukecwik
approved these changes
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These features have been discussed a bit on the mailing list and I get asked about them a bit. I think it is OK to list them here like we list retractions / metadata triggers, both of which are further from reality than checkpoint and drain.
I would have preferred to do the whole comparison rewrite of https://issues.apache.org/jira/browse/BEAM-2888 because the tabular form misleadingly implies these are yes/no features, when in reality they have many facets. But I haven't had time, and haven't convinced anyone else to take on that work.
So this is a low-effort compromise.
What do you think?
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.