Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image: provide a way to pass any desired configuration property via ENV vars #260

Closed
caliuf opened this issue Jul 19, 2017 · 3 comments
Assignees

Comments

@caliuf
Copy link
Contributor

caliuf commented Jul 19, 2017

In the first docker image PR (#197) emerged that could be useful to have a way to pass any desired configuration property at docker container creation.

@merlimat Proposed to use this python script, but it currently lacks the ability to substitute commented out properties. This could lead to undesired and difficult to debug issues for the end user.

This issue requires to import and enhance the script (and maybe to create a PR on the original repo) and update docker build files accordingly.

@jiazhai
Copy link
Member

jiazhai commented Jul 19, 2017

Based on Pulsar's script, I have already done a change satisfy our need, once PR #197 merged, I could do the PR.

@caliuf
Copy link
Contributor Author

caliuf commented Jul 19, 2017

It's awesome, thanks @jiazhai

@jiazhai
Copy link
Member

jiazhai commented Aug 6, 2017

fixed in #342

@jiazhai jiazhai closed this as completed Aug 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants