Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing "return -1" at discovery_naming_service.cpp:356 #1800

Closed
wudisheng opened this issue Jun 16, 2022 · 0 comments · Fixed by #1802
Closed

Missing "return -1" at discovery_naming_service.cpp:356 #1800

wudisheng opened this issue Jun 16, 2022 · 0 comments · Fixed by #1802

Comments

@wudisheng
Copy link

Describe the bug (描述bug)

To Reproduce (复现方法)

Expected behavior (期望行为)

Versions (各种版本)
OS:
Compiler:
brpc:
protobuf:

Additional context/screenshots (更多上下文/截图)
https://github.com/apache/incubator-brpc/blob/60159fc3f3e13490fb9806ea0a0cb0dcdbda7f7d/src/brpc/policy/discovery_naming_service.cpp#L356

Crash is observed without a "return -1" there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix discovery naming service core serverglen/brpc
1 participant
@wudisheng