Skip to content

Commit

Permalink
fix(builder): Fix race-condition when Build transitions to running phase
Browse files Browse the repository at this point in the history
  • Loading branch information
astefanutti committed Aug 4, 2021
1 parent 66bdc88 commit 3f3ba2e
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions pkg/controller/build/monitor_routine.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@ func (action *monitorRoutineAction) Handle(ctx context.Context, build *v1.Build)
build.Status.Error = "Build routine exists"
return build, nil
}
// Start the build asynchronously to avoid blocking the reconcile loop
status := v1.BuildStatus{Phase: v1.BuildPhaseRunning}
if err := action.updateBuildStatus(ctx, build, status); err != nil {
return nil, err
}
// Start the build asynchronously to avoid blocking the reconciliation loop
routines.Store(build.Name, true)
go action.runBuild(build)

Expand All @@ -92,11 +96,7 @@ func (action *monitorRoutineAction) runBuild(build *v1.Build) {
ctxWithTimeout, cancel := context.WithDeadline(ctx, build.Status.StartedAt.Add(build.Spec.Timeout.Duration))
defer cancel()

status := v1.BuildStatus{Phase: v1.BuildPhaseRunning}
if err := action.updateBuildStatus(ctx, build, status); err != nil {
return
}

status := v1.BuildStatus{}
buildDir := ""
Builder := builder.New(action.client)

Expand Down

0 comments on commit 3f3ba2e

Please sign in to comment.