Set the IntegrationConditionServiceNotAvailableReason only when the service trait is disabled

[aldettinger]

In the context of #1142, the TestApplyPrometheusTraitWithServiceDoesNotSucceed test shows that the IntegrationConditionServiceNotAvailableReason could be set while the service trait is enabled.

[lburgazzoli]

Not sure about that as the reason is also used to signal errors or other conditions for which the service cannot be enabled, see

camel-k/pkg/trait/service.go

Lines 71 to 95 in 8a71906

	if t.Auto == nil || *t.Auto {
	sources, err := kubernetes.ResolveIntegrationSources(t.ctx, t.client, e.Integration, e.Resources)
	if err != nil {
	e.Integration.Status.SetCondition(
	v1.IntegrationConditionServiceAvailable,
	corev1.ConditionFalse,
	v1.IntegrationConditionServiceNotAvailableReason,
	err.Error(),
	)
	return false, err
	}
	meta := metadata.ExtractAll(e.CamelCatalog, sources)
	if !meta.RequiresHTTPService {
	e.Integration.Status.SetCondition(
	v1.IntegrationConditionServiceAvailable,
	corev1.ConditionFalse,
	v1.IntegrationConditionServiceNotAvailableReason,
	"no http service required",
	)
	return false, nil
	}
	}

[aldettinger]

Indeed, we could imagine that the aborted service trait configuration cases mentioned above would not be covered then. Stepping back a bit, it looks that the implicit assumption that only the service trait is creating the service is respected at this stage. So I'm gonna close this issue, feel free to re-open if I missed something.