Added unit tests for the prometheus trait #255 #1142
Conversation
| assert.Equal(t, corev1.ConditionFalse, condition.Status) | ||
| } | ||
|
|
||
| func TestApplyPrometheusTraitWithServiceDoesNotSucceed(t *testing.T) { |
There was a problem hiding this comment.
2 more eyes are welcome there. when applying the trait with an existing service, the status outcome is IntegrationConditionServiceNotAvailableReason. Correct ?
There was a problem hiding this comment.
I'm not sure about that.. maybe @jamesnetherton can shed some light..
There was a problem hiding this comment.
The IntegrationConditionServiceNotAvailableReason reason should only be set on the condition when the service trait is disabled. Otherwise, this is a bug. Note that the current logic of the Prometheus trait may not be very robust as it makes the implicit assumption that only the service trait can create a service beforehand.
There was a problem hiding this comment.
Just a small issue then, I've opened #1149 to keep track. I'll rebase, thanks for review 👍
No description provided.