Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement install command's flags test #1158

Closed
valdar opened this issue Dec 18, 2019 · 1 comment · Fixed by #1883
Closed

Implement install command's flags test #1158

valdar opened this issue Dec 18, 2019 · 1 comment · Fixed by #1883
Labels
good first issue Does not require full understanding of the codebase
Milestone
1.4.0

Comments

@valdar
Copy link
Member

valdar commented Dec 18, 2019 •
edited
Loading

Implement install command's flags tests: https://github.com/apache/camel-k/blob/master/pkg/cmd/install_test.go#L43

One can draw inspiration from run command tests: https://github.com/apache/camel-k/blob/master/pkg/cmd/run_test.go
@valdar valdar added the good first issue Does not require full understanding of the codebase label Dec 18, 2019
@nicolaferraro nicolaferraro added this to the 1.0.0-RC2 milestone Dec 18, 2019
@nicolaferraro nicolaferraro modified the milestones: 1.0.0-RC2, 1.0.0-future Feb 20, 2020
@nicolaferraro nicolaferraro modified the milestones: 1.0.0, post 1.0.0 Apr 28, 2020
@nicolaferraro nicolaferraro modified the milestones: 1.3.0, 1.4.0 Dec 22, 2020
@squakez
Copy link
Contributor

squakez commented Jan 7, 2021

I can have a look at this

squakez added a commit to squakez/camel-k that referenced this issue Jan 7, 2021
@squakez
feat(test): install command flags unit test
9e1a053 
Added a suite of testcases to verify default and user provided flags

Closes apache#1158
This was referenced Jan 7, 2021
Merged
Closed
squakez added a commit to squakez/camel-k that referenced this issue Jan 7, 2021
@squakez
feat(test): install command flags unit test
543abc5 
Added a suite of testcases to verify default and user provided flags

Closes apache#1158
astefanutti pushed a commit that referenced this issue Jan 8, 2021
@squakez @astefanutti
feat(test): install command flags unit test
dede785 
Added a suite of testcases to verify default and user provided flags

Closes #1158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Does not require full understanding of the codebase
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

feat(test): install command flags unit test squakez/camel-k
3 participants
@valdar @nicolaferraro @squakez