Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add condition/status to monitor running state of the integration #1171

Closed
nicolaferraro opened this issue Dec 20, 2019 · 3 comments · Fixed by #1438
Closed

Add condition/status to monitor running state of the integration #1171

nicolaferraro opened this issue Dec 20, 2019 · 3 comments · Fixed by #1438
Assignees
Milestone

Comments

@nicolaferraro
Copy link
Member

A condition should signal if the integration is actually running and not in error (or any other state), no matter the number of replicas (should work also with 0).

We set the desired number of replicas in the status, but it should be empty if unspecified. Another field should map the current number of replicas. Another field should contain the number of ready replicas.

These fields are useful in order to do assertions on the integration state in scripts or testing tools.

@nicolaferraro nicolaferraro added this to the 1.0.0-RC2 milestone Dec 20, 2019
@astefanutti
Copy link
Member

astefanutti commented Dec 20, 2019

The number of replicas in the status is the actual number of replicas, hence always exists. It should be straightforward to reconcile the number of ready replicas as well. The number of desired replicas is set in the spec.

@nicolaferraro
Copy link
Member Author

Right! 👍

@astefanutti
Copy link
Member

Having the number of ready replicas would be useful to trigger the GC as well.

@nicolaferraro nicolaferraro modified the milestones: 1.0.0-RC2, 1.0.0-future Feb 20, 2020
@nicolaferraro nicolaferraro self-assigned this Apr 29, 2020
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Apr 30, 2020
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Apr 30, 2020
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Apr 30, 2020
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Apr 30, 2020
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue May 4, 2020
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue May 4, 2020
nicolaferraro added a commit that referenced this issue May 5, 2020
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue May 8, 2020
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants