Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Probes not bound to Knative services #1341

Closed
nicolaferraro opened this issue Mar 12, 2020 · 0 comments · Fixed by #1342
Closed

Probes not bound to Knative services #1341

nicolaferraro opened this issue Mar 12, 2020 · 0 comments · Fixed by #1342
Assignees
@lburgazzoli
Labels
area/knative Related to Knative kind/bug Something isn't working
Milestone
1.0.0

Comments

@nicolaferraro
Copy link
Member

Running the example in:

With command:

kamel run API.java --open-api openapi.yaml --property-file application-prod.properties  -t probes.enabled=true -t probes.bind-port=8080

The Ksvc is populated with the following probes:

readinessProbe:
  successThreshold: 1
  tcpSocket:
    port: 0

No liveness probe.

It seems something attached by Knative, while my settings are lost.

Looking at the trait, the trait applies only to deployments, while it should look for containers in the collection.
@nicolaferraro nicolaferraro added kind/bug Something isn't working area/knative Related to Knative labels Mar 12, 2020
@nicolaferraro nicolaferraro added this to the 1.0.0 milestone Mar 12, 2020
@lburgazzoli lburgazzoli self-assigned this Mar 12, 2020
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Mar 12, 2020
@lburgazzoli
Probes not bound to Knative services apache#1341
8fc3bda
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Mar 13, 2020
@lburgazzoli
Probes not bound to Knative services apache#1341
90b7e86
@lburgazzoli lburgazzoli mentioned this issue Mar 13, 2020
Merged
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Mar 13, 2020
@lburgazzoli
Probes not bound to Knative services apache#1341
17dc406
nicolaferraro pushed a commit that referenced this issue Mar 13, 2020
@lburgazzoli @nicolaferraro
Probes not bound to Knative services #1341
7046da6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lburgazzoli lburgazzoli

Labels
area/knative Related to Knative kind/bug Something isn't working
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Probes not bound to Knative services lburgazzoli/apache-camel-k
2 participants
@lburgazzoli @nicolaferraro