Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kamel uninstall leftovers #1465

Closed
ipolyzos opened this issue May 26, 2020 · 4 comments
Closed

Kamel uninstall leftovers #1465

ipolyzos opened this issue May 26, 2020 · 4 comments
Assignees
Milestone

Comments

@ipolyzos
Copy link
Contributor

On a clean namespace i.e

  $ kubectl get all,pvc,configmap,rolebindings,clusterrolebindings,secrets,sa,roles,clusterroles,crd -l 'app=camel-k'
  No resources found in default namespace.

When I try to uninstall a new clean installation of Camel-k not all resources removed. The crd and clusterrole remain installed i.e

  $ kamel install 
  Camel K installed in namespace default 
  $ kamel uninstal
  Camel K Integration Platform removed from namespace default
  Camel K Config Maps removed from namespace default
  Camel K Operator removed from namespace default
  Camel K Role Bindings removed from namespace default
  Camel K Roles removed from namespace default
  Camel K Service Accounts removed from namespace default
  $ kubectl get all,pvc,configmap,rolebindings,clusterrolebindings,secrets,sa,roles,clusterroles,crd -l 'app=camel-k'   
  NAME                                                 CREATED AT
  clusterrole.rbac.authorization.k8s.io/camel-k:edit   2020-05-26T15:26:52Z

  NAME                                                                                  CREATED AT
  customresourcedefinition.apiextensions.k8s.io/builds.camel.apache.org                 2020-05-26T15:26:52Z
  customresourcedefinition.apiextensions.k8s.io/camelcatalogs.camel.apache.org          2020-05-26T15:26:52Z
  customresourcedefinition.apiextensions.k8s.io/integrationkits.camel.apache.org        2020-05-26T15:26:52Z
  customresourcedefinition.apiextensions.k8s.io/integrationplatforms.camel.apache.org   2020-05-26T15:26:52Z
  customresourcedefinition.apiextensions.k8s.io/integrations.camel.apache.org           2020-05-26T15:26:52Z
@ipolyzos
Copy link
Contributor Author

Fix submitted. I can confirm now that on a clean namespace i.e

$ kubectl get all,pvc,configmap,rolebindings,clusterrolebindings,secrets,sa,roles,clusterroles,crd -l 'app=camel-k'                                                                     git:(master|✚2 
No resources found in default namespace.

When I try to uninstall a clean installation of Camel-k the CRD and ClusterRole are also removed i.e

$ kamel install 
Camel K installed in namespace default 
$ kubectl get all,pvc,configmap,rolebindings,clusterrolebindings,secrets,sa,roles,clusterroles,crd -l 'app=camel-k'     git:(kamel-uninstall-remove-crd-clusterrole|✚2 
NAME                                   READY   STATUS              RESTARTS   AGE
pod/camel-k-operator-89fb65586-npmb6   0/1     ContainerCreating   0          6s

NAME                               READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/camel-k-operator   0/1     1            0           6s

NAME                                         DESIRED   CURRENT   READY   AGE
replicaset.apps/camel-k-operator-89fb65586   1         1         0       6s

NAME                                                                     ROLE                                    AGE
rolebinding.rbac.authorization.k8s.io/camel-k-operator                   Role/camel-k-operator                   6s
rolebinding.rbac.authorization.k8s.io/camel-k-operator-events            Role/camel-k-operator-events            6s
rolebinding.rbac.authorization.k8s.io/camel-k-operator-servicemonitors   Role/camel-k-operator-servicemonitors   6s

NAME                              SECRETS   AGE
serviceaccount/camel-k-operator   1         6s

NAME                                                              CREATED AT
role.rbac.authorization.k8s.io/camel-k-operator                   2020-05-26T15:59:13Z
role.rbac.authorization.k8s.io/camel-k-operator-events            2020-05-26T15:59:13Z
role.rbac.authorization.k8s.io/camel-k-operator-servicemonitors   2020-05-26T15:59:13Z

NAME                                                 CREATED AT
clusterrole.rbac.authorization.k8s.io/camel-k:edit   2020-05-26T15:26:52Z

NAME                                                                                  CREATED AT
customresourcedefinition.apiextensions.k8s.io/builds.camel.apache.org                 2020-05-26T15:26:52Z
customresourcedefinition.apiextensions.k8s.io/camelcatalogs.camel.apache.org          2020-05-26T15:26:52Z
customresourcedefinition.apiextensions.k8s.io/integrationkits.camel.apache.org        2020-05-26T15:26:52Z
customresourcedefinition.apiextensions.k8s.io/integrationplatforms.camel.apache.org   2020-05-26T15:26:52Z
customresourcedefinition.apiextensions.k8s.io/integrations.camel.apache.org           2020-05-26T15:26:52Z
$ kamel uninstall   
Camel K Integration Platform removed from namespace default
Camel K Config Maps removed from namespace default
Camel K Operator removed from namespace default
Camel K Role Bindings removed from namespace default
Camel K Roles removed from namespace default
Camel K Service Accounts removed from namespace default
$ kubectl get all,pvc,configmap,rolebindings,clusterrolebindings,secrets,sa,roles,clusterroles,crd -l 'app=camel-k'     git:(kamel-uninstall-remove-crd-clusterrole|✚3 
No resources found in default namespace.

@davsclaus davsclaus added this to the 1.0.0 milestone May 27, 2020
@nicolaferraro
Copy link
Member

See comment on #1466 (comment)

Maybe we can document that for a complete uninstall you should pass some additional flags, but I wouldn't do it by default.

ipolyzos added a commit to ipolyzos/camel-k that referenced this issue May 27, 2020
ipolyzos added a commit to ipolyzos/camel-k that referenced this issue May 27, 2020
ipolyzos added a commit to ipolyzos/camel-k that referenced this issue May 27, 2020
ipolyzos added a commit to ipolyzos/camel-k that referenced this issue May 27, 2020
ipolyzos added a commit to ipolyzos/camel-k that referenced this issue May 27, 2020
ipolyzos added a commit to ipolyzos/camel-k that referenced this issue May 28, 2020
ipolyzos added a commit to ipolyzos/camel-k that referenced this issue May 28, 2020
ipolyzos added a commit to ipolyzos/camel-k that referenced this issue May 28, 2020
ipolyzos added a commit to ipolyzos/camel-k that referenced this issue May 28, 2020
ipolyzos added a commit to ipolyzos/camel-k that referenced this issue May 28, 2020
ipolyzos added a commit to ipolyzos/camel-k that referenced this issue May 28, 2020
ipolyzos added a commit to ipolyzos/camel-k that referenced this issue May 28, 2020
ipolyzos added a commit to ipolyzos/camel-k that referenced this issue May 28, 2020
@ipolyzos
Copy link
Contributor Author

@nicolaferraro a provisional change in the docs issued with PR #1475, if you could please review it would be great

@nicolaferraro
Copy link
Member

This has been implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants