Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating a new tag, make sure it's strictly numeric (i.e. 1.1.0 instead of v1.1.0) #1645

Closed
bfitzpat opened this issue Jul 27, 2020 · 1 comment

Comments

@bfitzpat
Copy link
Contributor

Discovered that the new tag of Camel K causes issues when the tooling tries to download it.

The new 1.1.0 version is tagged as "v1.1.0" whereas the rest of the versions are all 1.0.1, 1.0.0, etc. with no "v" - https://github.com/apache/camel-k/releases/tag/v1.1.0 vs. https://github.com/apache/camel-k/releases/tag/1.0.1

That extra "v" creates an issue in the url we construct to download the runtime CLI

Not found - https://github.com/apache/camel-k/releases/download/v1.1.0/camel-k-client-v1.1.0-linux-64bit.tar.gz
Found - https://github.com/apache/camel-k/releases/download/v1.1.0/camel-k-client-1.1.0-linux-64bit.tar.gz

We will work on avoiding this kind of problem in the tooling, but it caught us off guard and broke the download process.

@bfitzpat
Copy link
Contributor Author

Looks like this is a necessary change. I was not aware of #1603 and #1601. Will close and we are adapting the version checking to be better in the tooling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant