Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'v' prefix to tag names #1601

Closed
abkieling opened this issue Jul 9, 2020 · 2 comments · Fixed by #1603
Closed

Add 'v' prefix to tag names #1601

abkieling opened this issue Jul 9, 2020 · 2 comments · Fixed by #1603
Milestone

Comments

@abkieling
Copy link

Apparently go modules requires the 'v' prefix in tag names to correctly add them to go.mod. When the tag names don't include the 'v' prefix, go modules falls back to a pseudo-version.

@miguelsorianod
Copy link

miguelsorianod commented Jul 9, 2020

Hi,

The reason this issue has been opened is due to in our project https://github.com/redhat-integration/rhi-operator (fork of integreatly-operator) we are making use of camel-k and while I was investigating an issue I found camel-k was being imported using a pseudo-version due to tags in the repository not using format v.X.Y.Z (See details of the findings here https://github.com/redhat-integration/rhi-operator/pull/7#issuecomment-656259127)

However, I'd not take this decision lightly. Before taking this decision of changing the tags format you publish I would carefully evaluate when/if making this change makes sense or not, as Go modules treat v.X.Y.Z tags and module paths in a very specific way depending on whether X is 0,1,2. It seems doing that has some important implications regarding project structure organization, urls, paths etc.

I think the following following documentation might be of interest when evaluating this change:

@nicolaferraro
Copy link
Member

That for sure can be done, starting from next v1.1.0 release.

Another thing that we should do is re-pointing our 3 modules to use tag names instead of v0.0.0 before we do the tag, this way a project importing client or the full project doesn't need to go mod replacing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants