Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Knative endpoints and kameletbinding work with broker without explicit event type #1840

Closed
nicolaferraro opened this issue Dec 2, 2020 · 0 comments · Fixed by #2115
Closed

Make Knative endpoints and kameletbinding work with broker without explicit event type #1840

nicolaferraro opened this issue Dec 2, 2020 · 0 comments · Fixed by #2115
Assignees
@nicolaferraro
Milestone
1.4.0

Comments

@nicolaferraro
Copy link
Member

nicolaferraro commented Dec 2, 2020 •
edited
Loading

Needs runtime 1.6.x (apache/camel-k-runtime#568)

This should be legal (receiving all events from the broker without filters):

from("knative:event").to("log:info")

This should be legal as well (sending event without explicit event type) and the recipient should see the default event type:

from("timer:tick").to("knative:event")

Other cases:

  • KameletBinding from Kamelet to Broker without explicit event type
  • KameletBinding from Broker to Kamelet without explicit event type

All 4 cases need some e2e tests (after fixing the problematic code).
@nicolaferraro nicolaferraro added this to the 1.3.0 milestone Dec 2, 2020
@nicolaferraro nicolaferraro changed the title Add e2e tests about kameletbinsing with broker without explicit event type Add e2e tests about kameletbinding with broker without explicit event type Dec 2, 2020
@nicolaferraro nicolaferraro changed the title Add e2e tests about kameletbinding with broker without explicit event type Make Knative endpoints and kameletbinding work with broker without explicit event type Dec 2, 2020
@nicolaferraro nicolaferraro modified the milestones: 1.3.0, 1.4.0 Dec 22, 2020
@nicolaferraro nicolaferraro self-assigned this Mar 11, 2021
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Mar 11, 2021
@nicolaferraro
Fix apache#1840: make event type optional when using Knative broker
f7a523c
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Mar 11, 2021
@nicolaferraro
Fix apache#1840: make event type optional when using Knative broker
74eb3f5
@nicolaferraro nicolaferraro mentioned this issue Mar 11, 2021
Merged
1 task
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Mar 12, 2021
@nicolaferraro
Fix apache#1840: make event type optional when using Knative broker
d21c0ee
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Mar 12, 2021
@nicolaferraro
Fix apache#1840: fix name of the service in tests
727cf3a
nicolaferraro added a commit that referenced this issue Mar 17, 2021
@nicolaferraro
Fix #1840: make event type optional when using Knative broker
07bb668
nicolaferraro added a commit that referenced this issue Mar 17, 2021
@nicolaferraro
Fix #1840: fix name of the service in tests
102a5fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolaferraro nicolaferraro

Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Fix knative subscriptions and triggers nicolaferraro/camel-k
1 participant
@nicolaferraro