[CLI] Kamel run does not check source file exists #1911
Comments
|
I can work on this if it's confirmed to be a bug. |
It may be a regression, it used to be the case |
squakez
added a commit
to squakez/camel-k
that referenced
this issue
Jan 15, 2021
* Changed the name of run.isLocal func to run.isLocalAndExists as the function does both things * Added a default switch case to report either the file doesn't exist or the URI scheme cannot be parsed * Added some unit test to verify error messages expected Fixes apache#1911
nicolaferraro
pushed a commit
that referenced
this issue
Jan 15, 2021
* Changed the name of run.isLocal func to run.isLocalAndExists as the function does both things * Added a default switch case to report either the file doesn't exist or the URI scheme cannot be parsed * Added some unit test to verify error messages expected Fixes #1911
|
this issue has milestone 1.3.1 set but it is no tpart of 1.3.x branch Line 383 in ed0456f Is it planned to backport it? (if it is a regression sounds a good idea) or the milestone needs to be updated? |
|
Yeah, I will take care of backporting to 1.3 too. |
squakez
added a commit
to squakez/camel-k
that referenced
this issue
Jan 21, 2021
* Changed the name of run.isLocal func to run.isLocalAndExists as the function does both things * Added a default switch case to report either the file doesn't exist or the URI scheme cannot be parsed * Added some unit test to verify error messages expected Fixes apache#1911
astefanutti
pushed a commit
that referenced
this issue
Jan 22, 2021
* Changed the name of run.isLocal func to run.isLocalAndExists as the function does both things * Added a default switch case to report either the file doesn't exist or the URI scheme cannot be parsed * Added some unit test to verify error messages expected Fixes #1911
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I wonder if this is a desired behavior. When running any integration which is missing the source file (ie
kamel run xyzwhere xyz file does not exists), the CLI does not check if the file exists, creating an empty integration. I wonder if this is a bug and we should verify that the file exists and returning an error instead.The text was updated successfully, but these errors were encountered: