Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky e2e test (cron-fallback) #1939

Closed
nicolaferraro opened this issue Jan 22, 2021 · 11 comments · Fixed by #1960
Closed

Flaky e2e test (cron-fallback) #1939

nicolaferraro opened this issue Jan 22, 2021 · 11 comments · Fixed by #1960
Labels
area/continuous integration Related to CI and automated testing kind/bug Something isn't working
Milestone

Comments

@nicolaferraro
Copy link
Member

We need to fix this flaky e2e test:

--- FAIL: TestRunCronExample (310.61s)
    --- PASS: TestRunCronExample/cron (127.61s)
    --- PASS: TestRunCronExample/cron-timer (60.37s)
    --- FAIL: TestRunCronExample/cron-fallback (91.99s)

It happens often, e.g. https://github.com/apache/camel-k/runs/1747588145?check_suite_focus=true, but disappears after running the CI multiple times.

@nicolaferraro nicolaferraro added the kind/bug Something isn't working label Jan 22, 2021
@nicolaferraro nicolaferraro added this to the 1.4.0 milestone Jan 22, 2021
@nicolaferraro nicolaferraro added the kind/task General activity label Jan 22, 2021
@astefanutti
Copy link
Member

astefanutti commented Jan 22, 2021

Note that I've faced the issue by running the TestRunCronExample/cron-fallback e2e test locally as well, so it does not seem CI environment specific.

@nicolaferraro
Copy link
Member Author

Note that I've faced the issue by running the TestRunCronExample e2e test locally as well, so it does not seem CI environment specific.

Uh, so why sometimes it passes 🤦 ?

@astefanutti
Copy link
Member

That's a good question 😉.

I've looked at the dependencies and it seems the quartz dependencies are added correctly. It may be an issue with how Quarkus resolve classes...

@nicolaferraro
Copy link
Member Author

That's a good question .

I've looked at the dependencies and it seems the quartz dependencies are added correctly. It may be an issue with how Quarkus resolve classes...

This works:

kamel local run cron-fallback.groovy -d camel-quarkus:quartz -d camel-quarkus:cron

So I guess the camel-quarkus:cron dependency is missing for some reason.

@astefanutti
Copy link
Member

astefanutti commented Jan 22, 2021

Hum that's what I did (adding the extra dependencies, not running it locally) and thought too, but IIRC if failed randomly also. Have you tried to run it multiple times?

@nicolaferraro
Copy link
Member Author

Hum that's what I did (adding the extra dependencies, not running it locally) and thought too, but IIRC if failed randomly also. Have you tried to run it multiple times?

No, it seems to work.. at least locally..

@astefanutti
Copy link
Member

astefanutti commented Jan 22, 2021

OK, sounds good. It'd better be that. I did my tests quickly as I was bringing CI back on track, so I may have overlooked things or forgotten others 😀.

@nicolaferraro
Copy link
Member Author

Found it! Catalog contains both:

    camel-k-cron:
      groupId: org.apache.camel.k
      artifactId: camel-k-cron
      schemes:
      - id: cron
        http: false
        passive: false

And

    camel-quarkus-cron:
      groupId: org.apache.camel.quarkus
      artifactId: camel-quarkus-cron
      schemes:
      - id: cron
        http: false
        passive: false
      javaTypes:
      - org.apache.camel.component.cron.CronComponent

So depending on the status of some butterflies, the right component gets loaded.

I think camel-quarkus-cron is the right one, the other is part of the cron capability.
Opening issue in the runtime.

@astefanutti
Copy link
Member

The needle in the haystack 😄. That was too much cron dependencies for me :)

@astefanutti
Copy link
Member

And you've just cut the project CI budget by half 👍🏼!

@nicolaferraro
Copy link
Member Author

Yeah, that's why restarting CI 2-3 times was working XD

@astefanutti astefanutti added area/continuous integration Related to CI and automated testing and removed kind/task General activity labels Jan 25, 2021
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Jan 29, 2021
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Feb 2, 2021
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Feb 2, 2021
@nicolaferraro nicolaferraro modified the milestones: 1.4.0, 1.3.2 Feb 2, 2021
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Feb 2, 2021
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Feb 2, 2021
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/continuous integration Related to CI and automated testing kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants