Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SinkBinding produces errored pods on 0.18+ / OpenShift Serverless 1.12 #1945

Closed
nicolaferraro opened this issue Jan 25, 2021 · 1 comment
Closed

SinkBinding produces errored pods on 0.18+ / OpenShift Serverless 1.12 #1945

nicolaferraro opened this issue Jan 25, 2021 · 1 comment
Labels
area/knative Related to Knative kind/bug Something isn't working
Milestone
1.5.0

Comments

@nicolaferraro
Copy link
Member

Testing on OpenShift serverless.

When a pod that uses sink-binding is run, the webhook on deployments seems not to be applied immediately, so this results into two deployments, one of which does not contain the injected parameters and ends in an error state.

We should investigate why the Knative webhook does not change the deployment immediately and if we can put some countermeasures to avoid the double deployment.

Making the integration itself sink-bindable is a possible strategy.
@nicolaferraro nicolaferraro added kind/bug Something isn't working area/knative Related to Knative labels Jan 25, 2021
@nicolaferraro nicolaferraro added this to the 1.4.0 milestone Jan 25, 2021
@nicolaferraro nicolaferraro modified the milestones: 1.4.0, 1.5.0 Apr 13, 2021
@astefanutti
Copy link
Member

I think it's been fixed with #2190.

@astefanutti astefanutti mentioned this issue Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/knative Related to Knative kind/bug Something isn't working
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
2 participants
@astefanutti @nicolaferraro