Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add label to SinkBinding sources #2190

merged 2 commits into from Apr 6, 2021


Copy link

@astefanutti astefanutti commented Apr 2, 2021

This PR makes sure the Eventing webhook will select the source resources, in order to inject the sink information.

This is necessary for Knative environments, that are configured with SINK_BINDING_SELECTION_MODE=inclusion. See:

Fixes #2184.

Release Note

fix: Add label to SinkBinding sources

Copy link
Member Author

astefanutti commented Apr 15, 2021

It should also fix #1945.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

[regression] 1.3.2 regresses on "SinkBinding on KSVC results into ping-pong between operators #1936"
3 participants